Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

DO Alarms patch #294

Merged
merged 10 commits into from
Jun 28, 2022
Merged

Conversation

CraigglesO
Copy link
Contributor

@CraigglesO CraigglesO commented Jun 21, 2022

Aims to solve #290 behavior mismatch.

TODO:

  • Check with devs on what proper response to setAlarm(0) is
  • Add new tests

@CraigglesO
Copy link
Contributor Author

@mrbbot - ready for review! 💯 🎊 🇦🇶 🐺 🐶 🔩 👾 🛰️

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✅ A couple minor things, but happy to merge as is. 🎉

@CraigglesO
Copy link
Contributor Author

Should be ready now. 🎊

@mrbbot mrbbot merged commit 5c5b0ad into cloudflare:master Jun 28, 2022
@mrbbot mrbbot mentioned this pull request Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants