This repository has been archived by the owner on Feb 19, 2025. It is now read-only.
Add basic expanded sflow tests #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lspgn
reviewed
Jan 6, 2020
|
LGTM. Thank you for writing the test :) . |
|
Sorry I've been taking too long at verifying this PR. Are you sure you want to share a real sFlow sample? I'm noticing a few ip addresses in there that don't seem to be obfuscated. |
|
I merged two flow samples into one so it should not represent real communication. Do you think it is not safe still? |
|
I'd be careful in case of an audit: non-obfuscated PII (even if long ago) since it's the full sFlow packet. |
tgragnato
pushed a commit
to tgragnato/goflow
that referenced
this pull request
Aug 14, 2024
…control Add flags to control Kafka Flush parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been debugging expanded sflow parsing and for that I wrote these 2 tests.
(I was not sure it was being parsed properly. The error in the end was in reading prometheus metrics (wrong label filter) so everything in goflow works as expected)
I though might share rather than removing it, WDYT?