This repository has been archived by the owner on Feb 19, 2025. It is now read-only.
Add FlowTimeStart and FlowTimeEnd #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Will give it a try and hopefully will merge :) . Thank you! |
lspgn
approved these changes
May 1, 2019
tgragnato
referenced
this pull request
in tgragnato/goflow
Aug 14, 2024
Enricher can set sampling rate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #22
As discussed in the issue, this adds both time fields and marks the
TimeFlowfield for eventual deprecation. The mentioned processing speed limitations do not appear to be a problem, see the following screenshot of the 99th percentile of goflow speed metrics from my monitoring.I've tested NFv9 and am confident that IPFIX will work too, but I am unsure about the sFlow implementation. The latest two commits shave some bytes of a single flow message, but I am unsure about it, as
TimeRecvdis the same anyways. It might be best to populate all three fields with the same value, or to leave bothTimeFlow*empty.