This repository has been archived by the owner on Feb 19, 2025. It is now read-only.
Add VRF information to flow messages #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ingressVrfIdandegressVrfIdto the flow message protobuf, as well as the required handling on the producer side.It also includes these fields in
NFv9TypeToString, which is technically incorrect. The Cisco ASR9k Series of routers (and probably other IOS-XR platforms as well) however include these two fields (234 and 235) in their Netflow v9 templates, "borrowing" from IPFIX. But as far as I can tell, this is never executed during regular goflow usage.This code is tested with said NFv9 from different AS9k and IOS-XR versions and will most probably work for IPFIX as well.