This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Thellimist/pi 721 #103
Merged
Thellimist/pi 721 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| $apiResponse = $apiRouter->getAPIClient()->createAPIError("CSRF Token not valid."); | ||
| } | ||
| $response = $requestRouter->route($request); |
There was a problem hiding this comment.
Can't remove the CSRF check logic - need:
if($isCSRFTokenValid) {
$apiResponse = $apiRouter->route($request);
}
| if ($isCSRFTokenValid) { | ||
| $response = $requestRouter->route($request); | ||
| } else { | ||
| $response = $apiRouter->getAPIClient()->createAPIError('CSRF Token not valid.'); |
There was a problem hiding this comment.
$apiRouter doesn't exist anymore. Just have the response be the string "CSRF Token not valid, please refresh the page.". 90% of the times this happens it will be malicious so its okay if its not pretty.
There was a problem hiding this comment.
Good catch. A single string response would not be shown in the error notifications. Response should be a full response object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.