Use LoadFile() and resolve dependencies manually #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfb5be5 to
44709b0
Compare
LoadFile() works on both dotnet Framework 47 and dotnet Core. The downside is that we need to manually resolve dependencies for the custom serializer assembly on dotnet Core. On dotnet Framework there seems to be different behavior in terms of assembly resolution, and as long as the required assembly is in the same folder as the requesting assembly, it loads fine. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
44709b0 to
0fd6c93
Compare
|
I took your advice and went with On dotnet core however, this handler is absolutely needed. Let me know if you have any thoughts on this PR or if you see anything really funky. |
|
merging this. Will revert before release if it turns out to be a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadFile() works on both dotnet Framework 47 and dotnet Core. The downside is that we need to manually resolve dependencies for the custom serializer assembly on dotnet Core. On dotnet Framework there seems to be different behavior in terms of assembly resolution, and as long as the required assembly is in the same folder as the requesting assembly, it loads fine.