Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding connection_name with a different value #187

Closed
mrtus opened this issue Nov 6, 2024 · 2 comments · Fixed by #189
Closed

Allow overriding connection_name with a different value #187

mrtus opened this issue Nov 6, 2024 · 2 comments · Fixed by #189

Comments

@mrtus
Copy link

mrtus commented Nov 6, 2024

👋

We'd like to have the ability to configure a connection name through an environment variable.

This way we can easily identify the connections with e.g. the K8S pod name.
Currently, it is configured so that it is AMQProxy + version https://github.com/cloudamqp/amqproxy/blob/main/src/amqproxy/upstream.cr#L235 and is thus displayed as 👇, which does not help us a lot to identify where the actual connection is coming from, without having to match IP addresses
image

@carlhoerberg
Copy link
Member

ok! good suggestion!

carlhoerberg added a commit that referenced this issue Nov 11, 2024
Kubernetes exposes the podname via the `gethostname` glibc call. This
will show the podname as the easy to read identifier for the connection.

Fixes #187

Could expose it as a config variable too, but I think this addresses the
need and is much simplier, both as a patch and for the user to use.
@mrtus
Copy link
Author

mrtus commented Nov 26, 2024

I can confirm this change works as expected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants