Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

add option to propagate binaries without access to internet #124

Closed

Conversation

koroglusaban
Copy link

its allow to download binary from own store

@paulfantom
Copy link
Member

Please fix issues reported by Travis CI: https://travis-ci.com/cloudalchemy/ansible-node-exporter/jobs/258266272#L280-L288 and add molecule tests. Everything can be found in cloudalchemy/ansible-prometheus#239

@paulfantom paulfantom added area/tasks Logic behind ansible role area/vars Ansible variables used in role labels Nov 19, 2019
@koroglusaban
Copy link
Author

Styling errors are fixed

@paulfantom
Copy link
Member

paulfantom commented Nov 20, 2019

Great job on fixing errors. 👍

This still needs molecule tests before it is merged.

@koroglusaban
Copy link
Author

@paulfantom
Copy link
Member

This is our CI output of molecule tests. You can run those locally by following https://github.com/cloudalchemy/ansible-node-exporter#local-testing.

What we need is to extend those to cover feature included in this PR, same way as it is happening in cloudalchemy/ansible-prometheus#239

@koroglusaban
Copy link
Author

@paulfantom
Copy link
Member

Sorry, but I don't know what I have to do with this file.

I was saying about adding molecule tests in code to this PR. Things like this:


Additionally. I just noticed that this PR is adding new variable to defaults/main.yml. This needs to be reflected in README.md file in Role Variables section.

@paulfantom
Copy link
Member

Closing as this was already done in #126

@paulfantom paulfantom closed this Dec 5, 2019
@paulfantom paulfantom added the wontfix This will not be worked on label Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tasks Logic behind ansible role area/vars Ansible variables used in role wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants