Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Adjust systemd restrictions #90

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

corny
Copy link
Contributor

@corny corny commented Oct 1, 2019

  • ReadWriteDirectories needs to be set to store data
  • RestrictSUIDSGID has been introduced with Systemd 242

RemoveIPC=true
{% if alertmanager_systemd_version | int >= 242 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary as systemd discards options which it doesn't know about, prints a log message, and proceeds to start a service. So on older systemd versions service still will be started just without this parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to don't see noise about unknown options in my log messages.

Copy link
Member

@paulfantom paulfantom Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that but from the maintainer point of view I don't want to track which systemd option was introduced in which version, especially when there is an easy way allowing to not do that. Additionally, this would mean that if we want to have consistency then almost all systemd options would need to get such conditionals. This, in turn, would unneccessarily cloud jinja template and make it much less readable.

You can treat those log messages as notifications of what you will get if you upgrade to newer systemd :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that's reasonable for me.

ReadWriteDirectories needs to be set to store data
@paulfantom paulfantom merged commit b4230ff into cloudalchemy:master Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants