This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Move service creation from install to configure #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the service creation in the install tasks means that changes to the configuration, such as the web.external-url, are not updated with the configuration task. This creates a problem if configuration is re-applied, either as a separate step, or re-run for updating values. Moving the service creation to the configure step ensures any new or updated values are taken into account in the service execution.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the service creation in the install tasks means that changes to
the configuration, such as the web.external-url, are not updated with
the configuration task. This creates a problem if configuration is
re-applied, either as a separate step, or re-run for updating values.
Moving the service creation to the configure step ensures any new or
updated values are taken into account in the service execution.