This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Make template compatible with both Python 2 and 3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using this role in an environment where the default python interpreter is python3, the ansible run fails when jinja2 tries to process `templates/alertmanager.yml.j2`. This is because in Python 3, `dict` objects no longer have the `.iteritems()` method (see e.g.: https://wiki.python.org/moin/Python3.0, under "Built-in Changes"). For the purposes it's used in the template, `.items()` is functionally equivalent to `.iteritems()` except that it also works in Python 3.
|
Thanks! 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this role in an environment where the default python
interpreter is python3, the ansible run fails when jinja2 tries to
process
templates/alertmanager.yml.j2.This is because in Python 3,
dictobjects no longer have the.iteritems()method (see e.g.: https://wiki.python.org/moin/Python3.0,under "Built-in Changes").
For the purposes it's used in the template,
.items()is functionallyequivalent to
.iteritems()except that it also works in Python 3.Also, the implementation for looping over dictionary k/v pairs is now
consistent over both template files used in this role.