Fix broken stacktrace navigation to references of the form foo/eval16959/fn
#854
Conversation
| ;; stacktrace returns more accurate line numbers | ||
| (info (nrepl-dict-put info "line" (button-get button 'line)))) | ||
| (info (nrepl-dict-put info "line" (button-get button 'line))) | ||
| ;; info middleware returns full paths, but sometimes fails |
There was a problem hiding this comment.
"sometimes fails" is a bit confusing. If there's some problem with the middleware we should fix it there instead of doing a workaround here.
There was a problem hiding this comment.
The example that I have in mind is indeed has to do to the error in the middleware but with the old code user will not notice that because the message "No source location found" overshados the middleware error.
With the new code, you are taken to the location but the error in the middleware is also displayed.
There was a problem hiding this comment.
The middleware error should also be visible in the REPL buffer, so users are unlikely to miss it.
There was a problem hiding this comment.
Bozhidar Batsov on Fri, 17 Oct 2014 12:27:49 -0700 wrote:
The middleware error should also be visible in the REPL buffer, so users are
unlikely to miss it.
I was missing it till I started investigating what was going on. My repl
is full of my own user errors so I am completely ignoring it.
83dbbe3 to
6c35f1a
Compare
Java stacktrace reports lines even for methods of inner classes (seen as
foo.bar/evalNNNN in stacktrace). `info` middleware doesn't return location for
these methods and there is no easy way to access it as the following post
explains:
http://stackoverflow.com/questions/7483421/how-to-get-source-file-name-line-number-from-a-java-lang-class-object
|
All right. This patch is still needed even after fixing the middleware error in clojure-emacs/cider-nrepl#142.. I guess you would like a changelog for this as well. Now the problem is that all my 3 pulls have changelog entry and will conflict. /This is one of the reasons I hate changelog :-)/. So let's do like this, once all the PR's are closed I will add a change log for all of the changes. Otherwise I have to rebase all pulls on top of each other or synchronise with you and make it iteratively. |
Yes, this is the only significant downside, but I'm used to this already. :-)
Fair enough. I see a typo in the second commit and to be honest I totally forgot what this PR was supposed to fix. |
Eval with source tracking command and then go to the line with |
I don't see any. |
Fix broken stacktrace navigation to references of the form `foo/eval16959/fn`
My bad. I keep forgetting most people use American spelling ( |
I closed #850 prematurely and cannot reopen it now. The problem is not fixed. Sometimes info middleware doesn't return file location. In those cases just pick the file from stacktrace.