Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-apropos blows up on invalid regular expressions #1563

Closed
bbatsov opened this issue Feb 14, 2016 · 2 comments
Closed

cider-apropos blows up on invalid regular expressions #1563

bbatsov opened this issue Feb 14, 2016 · 2 comments
Labels

Comments

@bbatsov
Copy link
Member

bbatsov commented Feb 14, 2016

We should process those specially and give some sensible feedback to the users instead of dumping a stacktrace on them.

@bbatsov bbatsov added the bug label Feb 14, 2016
@Malabarba
Copy link
Member

The regexp is used on the Clojure side, right?
If so, should be just a matter of using a try block somewhere in there.

@bbatsov
Copy link
Member Author

bbatsov commented Feb 14, 2016

Yeah, there should simply be specific handling for this exception and some specific processing of the return value on the Emacs side. Perhaps as importantly - it's not really clear the search key is a regexp (just as the Emacs's own apropos). We know it, but some users probably don't...

Malabarba added a commit that referenced this issue Feb 14, 2016
bbatsov added a commit to clojure-emacs/cider-nrepl that referenced this issue Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants