Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data reader import issue #56

Merged
merged 2 commits into from
Jun 6, 2020
Merged

Conversation

kolharsam
Copy link
Contributor

@kolharsam kolharsam commented May 29, 2020

this PR should fix #55

@jafingerhut thanks for your help in resolving this issue.

kolharsam added 2 commits May 29, 2020 17:41
this is was the solution discussed at clj-commons#55
these tests fail if the changes in the parent commit are not
present. thereby helping to resolve clj-commons#55
@kolharsam kolharsam requested a review from danielcompton as a code owner May 29, 2020 12:16
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@borkdude borkdude self-requested a review June 6, 2020 12:28
@borkdude borkdude merged commit e230cc9 into clj-commons:master Jun 6, 2020
@borkdude borkdude removed their request for review June 6, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data reader depends on imports being available?
3 participants