Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#50] fix reflection warnings #51

Merged
merged 1 commit into from
Apr 13, 2020
Merged

[#50] fix reflection warnings #51

merged 1 commit into from
Apr 13, 2020

Conversation

borkdude
Copy link
Contributor

@borkdude borkdude commented Apr 13, 2020 •
edited
Loading

This fixes #50.

@borkdude borkdude requested a review from danielcompton as a code owner April 13, 2020 09:11
@borkdude borkdude mentioned this pull request Apr 13, 2020
Merged
@jafingerhut
Copy link
Contributor

I have done a little bit of experimenting and thinking about the code on these changes, and I believe these additional type hints are correct, and agree that they eliminate the reflection warnings.

@slipset
Copy link
Member

slipset commented Apr 13, 2020

This is in line with what useful did
https://github.com/clj-commons/useful/blob/master/src/flatland/useful/experimental/delegate.clj#L56

@slipset slipset merged commit 9f0517c into clj-commons:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielcompton danielcompton Awaiting requested review from danielcompton danielcompton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ordered-1.5.8 gives reflection warnings
3 participants
@borkdude @jafingerhut @slipset