Go through all the open issues and PRs and apply their changes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Java 13+ compatiblity issues, as noted in clj-commons#23. Copying the relevant parts from the Issue: `java.nio.ByteBuffer` and the other buffer types in `java.nio` now define absolute bulk `get` and `put` methods to transfer contiguous sequences of bytes without regard to or effect on the buffer position. Due to this, running durable-queue against Java 13+ leads to the following error: No matching method put found taking 2 args for class `java.nio.DirectByteBuffer` This commit fixes the problem by adding the relevant type-hints Author: Mark Bastian Ref: https://github.com/markbastian/durable-queue Closes: clj-commons#23 Closes: clj-commons#24
System/currentTimeMillis is not guaranteed to progress monotonically. NTP shifts, leap seconds, and manual system time changes can all cause elapsed time calculations to be incorrect if you use currentTimeMillis. nanoTime is always calculated against a fixed point and proceeds monotonically. https://go.googlesource.com/proposal/+/master/design/12914-monotonic.md has a good discussion on monotonic time. Closes: clj-commons#21
The README contains documentation for these parameters, this commit copies them from the README into the docstring. Closes: clj-commons#20
This function lets the client delete an individual named queue. It is useful for deleting corrupted queue files (such as that get created when the disk fills up). Closes: clj-commons#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (and the master branch on my fork) contains (almost) all the fixes contributed by different members of the community. The only PR I haven't picked is #19 , since I am not sure that we should drop data that we have previously persisted to disk.
I've written the commit messages such that they capture the summary of all related conversations and will update all the linked issues / PRs if the commits are merged in.
Personally, my goal is as follows:
org.clj-commons/durable-queue.I will do this on my personal fork of the project and contribute it back here. Hopefully one of the maintainers can help me with a review and merge the changes in. I am using
durable-queueon a new project and since I'm reading through the code anyway I thought I might as well update the code.