Body encoding now applied and always defaults to UTF-8 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously always encoding to system default character encoding, which is UTF-8 unless on Windows then it is windows-1252. Now: - encoding body to requested body encoding - and defaulting to UTF-8 if no body encoding requested Also: - Added extended characters to http bodies in tests to exercise body encoding/decoding - Verified :auto body decoding with an extra test Note that :auto body decoding might not be entirely correct. It will only look at content-type charset if content-type starts with "text/". Diagnosing/fixing this is out of scope for this PR. Fixes clj-commons#18
borkdude
reviewed
Aug 13, 2022
|
Apart from the typo, LGTM. Feel free to merger after the typo fix. |
|
Thanks for the review! I'm having typo-blindness. Maybe it is just poorly worded? Maybe instead: If specified, body encoding is now applied, else defaults to UTF-8. I'll try that and maybe you can lemme know if there is still something amiss. |
|
For posterity, I had misspelled "respects"! Couldn't see it! Thanks @borkdude! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously always encoding to system default character encoding,
which is UTF-8 unless on Windows then it is windows-1252.
Now:
Also:
body encoding/decoding
Note that :auto body decoding might not be entirely correct.
It will only look at content-type charset if content-type starts with
"text/". Diagnosing/fixing this is out of scope for this PR.
Fixes #18