Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for GraalVM #2

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

ivarref
Copy link

@ivarref ivarref commented Dec 2, 2019

Hi

And thanks for a fine project!

When using clj-http-lite with GraalVM 19.3, I'm getting a strange stacktrace exception:

JVM Exception: #error {
 :cause java.net.URLEncoder
 :via
 [{:type java.lang.ClassNotFoundException
   :message java.net.URLEncoder
   :at [com.oracle.svm.core.hub.ClassForNameSupport forName ClassForNameSupport.java 60]}]
 :trace
 [[com.oracle.svm.core.hub.ClassForNameSupport forName ClassForNameSupport.java 60]
  [java.lang.Class forName DynamicHub.java 1197]
  [clojure.lang.RT classForName RT.java 2204]
  [clojure.lang.RT classForName RT.java 2213]
  [clj_http.lite.util$url_encode invokeStatic util.clj 28]
  [clj_http.lite.client$generate_query_string$fn__1889 invoke client.clj 150]
...

Adding these type hints solves this problem.

Would that be OK to include in the project?

Thanks
Kind regards

@martinklepsch martinklepsch merged commit 05d0454 into clj-commons:master Dec 4, 2019
@martinklepsch
Copy link
Collaborator

Thanks for testing this with Graal and opening a PR, I'll cut a new release now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants