Update logic on failing to parse the result #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Callback with the status instead of a JSON parse error
|
Nice fix... how about we meet halfway? We could return an object with both error and status code... and update any error handling to return this structure. That way, we get the best of both worlds, and we get consistent logging. Thoughts? |
|
Sounds good to me. Would passing the callback an object with two keys |
clintandrewhall
added a commit
that referenced
this pull request
Jul 12, 2018
Update logic on failing to parse the result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing an issue where Foursquare was sending a status
400, however the result was not parsable. This resulted in my callback getting called with"Unexpected end of JSON input"instead of a400. I experienced this issue with versionv0.3.2, but it seems that this will still be an issue with what is currently inv0.4.0.