Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade winston to clear vulnerability reported by snyk.io #31

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Conversation

YasharF
Copy link

@YasharF YasharF commented Oct 5, 2016

DISCLOSED: 01/19/2016, PUBLISHED: 03/22/2016

Remote Memory Exposure

Medium severity
Vulnerable module: request
Introduced through: winston@0.6.2
Detailed paths and remediation

Introduced through: node-foursquare@node-foursquare#080e97e512dfdf42ab42e9b2a83928405a7faebe › winston@0.6.2 › request@2.9.203

Remediation: Upgrade to winston@0.8.0.

Overview
A potential remote memory exposure vulnerability exists in request. If a request uses a multipart attachment and the body type option is number with value X, then X bytes of uninitialized memory will be sent in the body of the request.

Note that while the impact of this vulnerability is high (memory exposure), exploiting it is likely difficult, as the attacker needs to somehow control the body type of the request. One potential exploit scenario is when a request is composed based on JSON input, including the body type, allowing a malicious JSON to trigger the memory leak.

@YasharF
Copy link
Author

YasharF commented Oct 5, 2016

Can you please make sure that the change is published to npm repo?

Thanks

@clintandrewhall clintandrewhall merged commit 1024a13 into clintandrewhall:master Dec 12, 2017
@clintandrewhall
Copy link
Owner

I'll get this out right away. Sorry for the delay-- been heads down at work and not in github as often as I used to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants