-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support to v16 #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mcollina The CI is failing for v16 because it has introduced a different behavior when using const fs = require('fs')
const stream = require('stream')
const processStatEncoder = new stream.Transform()
const out = processStatEncoder.pipe(fs.createWriteStream(`example-${process.version}`))
process.exit() If you run it using v14 it will create the file, using v16 it doesn't create, looks like the I'll fix it by just running in the next tick, but it's important to note here. |
The remaining tests I'm not able to reproduce locally. But looks like it's indeterministic since the creation. https://github.com/clinicjs/node-clinic-doctor/actions |
@mcollina Can I merge it or should look at the flaky windows tests? |
Well, looks that ba904ed fixes it. Just for reference, it's needed because I'm a bit worried about that change on |
Address: clinicjs/node-clinic#295