Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clixon-lib yang revision file name update #92

Closed
preetjuniper opened this issue Aug 21, 2019 · 2 comments
Closed

clixon-lib yang revision file name update #92

preetjuniper opened this issue Aug 21, 2019 · 2 comments
Labels

Comments

@preetjuniper
Copy link

I saw the following when trying to start the clixon_backend in the main docker container:

Aug 21 20:08:43: yang_parse_filename /usr/local/share/clixon/clixon-lib@2019-06-05.yang
Aug 21 20:08:43: yang_spec_load_dir: 3081: Yang error: Yang module file revision and in yang does not match: /usr/local/share/clixon/clixon-lib@2019-06-05.yang vs 20190813: Invalid argument

Does the file need to be renamed? My temp workaround was

diff --git a/yang/clixon/Makefile.in b/yang/clixon/Makefile.in
index c982ddc..87d5e65 100644
--- a/yang/clixon/Makefile.in
+++ b/yang/clixon/Makefile.in
@@ -42,7 +42,7 @@ datarootdir     = @datarootdir@
 YANG_INSTALLDIR   = @YANG_INSTALLDIR@
 
 YANGSPECS       = clixon-config@2019-06-05.yang
-YANGSPECS      += clixon-lib@2019-06-05.yang
+YANGSPECS      += clixon-lib@2019-08-13.yang
 YANGSPECS      += clixon-rfc5277@2008-07-01.yang
 YANGSPECS      += clixon-xml-changelog@2019-03-21.yang
 
diff --git a/yang/clixon/clixon-lib@2019-06-05.yang b/yang/clixon/clixon-lib@2019-08-13.yang
similarity index 100%
rename from yang/clixon/clixon-lib@2019-06-05.yang
rename to yang/clixon/clixon-lib@2019-08-13.yang
@olofhagsand
Copy link
Member

I see there is a failure on the revert of a new revision (the intended upgrade of clixon-lib was reverted), but the new revision date is kept.
That is an error, but strangely I do not see it in the CI logs at https://travis-ci.org/clicon/clixon (which run as containers)
I need to dig deeper.
(The fix will most probably be as you made, to include a new revision although with null changes from the old)

olofhagsand added a commit that referenced this issue Aug 24, 2019
…with

RFC 8040 Sec 3.1
  * non-pretty print remove all spaces, eg `{"operations":{"clixon-example:client-rpc":[null]`
  * Replaced JSON `null` with `[null]` as proper empty JSON leaf/leaf-list encoding.
* [Cannot write to config using restconf example #91](#91)
  * Updated restconf documentation (the example was wrong)
* [clixon-lib yang revision file name update #92](#92)
  * Clixon-lib yang file had conflicting filename and internal yang revision.
  * This was only detected in the use-case when a whole dir was loaded.
  * Inserted sanity check in all yang parse routines.
  * Committed updated clixon-lib yang file that triggered the error
@olofhagsand
Copy link
Member

Fixed above

  • Clixon-lib yang file had conflicting filename and internal yang revision.
  • This was only detected in the use-case when a whole dir was loaded.
  • Inserted sanity check in all yang parse routines.
  • Committed updated clixon-lib yang file that triggered the error
    Thanks for detecting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants