Hello netconf candidate capability misspelled, mentioned in [Can clix…

…on_netconf receive netconf packets as a server? #93](#93)

CHANGELOG.md

@@ -8,6 +8,7 @@
   * Replaced JSON `null` with `[null]` as proper empty JSON leaf/leaf-list encoding.
 
 ### Corrected Bugs
+* Hello netconf candidate capability misspelled, mentioned in [Can clixon_netconf receive netconf packets as a server? #93](https://github.com/clicon/clixon/issues/93)
 * [Cannot write to config using restconf example #91](https://github.com/clicon/clixon/issues/91)
   * Updated restconf documentation (the example was wrong)
 * [clixon-lib yang revision file name update #92](https://github.com/clicon/clixon/issues/92)

README.md

@@ -7,7 +7,7 @@ Clixon is a YANG-based configuration manager, with interactive CLI,
 NETCONF and RESTCONF interfaces, an embedded database and transaction
 mechanism.
 
-See [main documentation](https://clixon-docs.readthedocs.io).
+See [main documentation](https://clixon-docs.readthedocs.io) and [project page](https://www.clicon.org).
 
 Clixon is open-source and dual licensed. Either Apache License, Version 2.0 or GNU
 General Public License Version 2; you choose.

apps/netconf/netconf_hello.c

@@ -133,7 +133,7 @@ netconf_hello_dispatch(cxobj *xn)
  *
  * Question: should the NETCONF in RFC6241 sections 8.2-8.9 be announced both 
  * as features and as capabilities in the <hello> message according to RFC6241?
- *   urn:ietf:params:netconf:capability:candidate:1:0 (8.3)
+ *   urn:ietf:params:netconf:capability:candidate:1.0 (8.3)
  *   urn:ietf:params:netconf:capability:validate:1.1 (8.6)
  *   urn:ietf:params:netconf:capability:startup:1.0 (8.7)
  *   urn:ietf:params:netconf:capability:xpath:1.0 (8.9)
@@ -169,7 +169,7 @@ netconf_create_hello(clicon_handle h,
 			    module_set_id) < 0)
 	goto done;
     cprintf(cb, "<capability>%s</capability>", encstr);
-    cprintf(cb, "<capability>urn:ietf:params:netconf:capability:candidate:1:0</capability>");
+    cprintf(cb, "<capability>urn:ietf:params:netconf:capability:candidate:1.0</capability>");
     cprintf(cb, "<capability>urn:ietf:params:netconf:capability:validate:1.1</capability>");
     cprintf(cb, "<capability>urn:ietf:params:netconf:capability:startup:1.0</capability>");
     cprintf(cb, "<capability>urn:ietf:params:netconf:capability:xpath:1.0</capability>");

test/test_netconf.sh

@@ -50,7 +50,7 @@ if [ $BE -ne 0 ]; then
 fi
 
 new "netconf hello"
-expecteof "$clixon_netconf -f $cfg" 0 '<rpc message-id="101"><get-config><source><candidate/></source></get-config></rpc>]]>]]>' '^<hello xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"><capabilities><capability>urn:ietf:params:netconf:base:1.0</capability><capability>urn:ietf:params:netconf:capability:yang-library:1.0?revision=2016-06-21&amp;module-set-id=42</capability><capability>urn:ietf:params:netconf:capability:candidate:1:0</capability><capability>urn:ietf:params:netconf:capability:validate:1.1</capability><capability>urn:ietf:params:netconf:capability:startup:1.0</capability><capability>urn:ietf:params:netconf:capability:xpath:1.0</capability><capability>urn:ietf:params:netconf:capability:notification:1.0</capability></capabilities><session-id>[0-9]*</session-id></hello>]]>]]><rpc-reply message-id="101"><data/></rpc-reply>]]>]]>$'
+expecteof "$clixon_netconf -f $cfg" 0 '<rpc message-id="101"><get-config><source><candidate/></source></get-config></rpc>]]>]]>' '^<hello xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"><capabilities><capability>urn:ietf:params:netconf:base:1.0</capability><capability>urn:ietf:params:netconf:capability:yang-library:1.0?revision=2016-06-21&amp;module-set-id=42</capability><capability>urn:ietf:params:netconf:capability:candidate:1.0</capability><capability>urn:ietf:params:netconf:capability:validate:1.1</capability><capability>urn:ietf:params:netconf:capability:startup:1.0</capability><capability>urn:ietf:params:netconf:capability:xpath:1.0</capability><capability>urn:ietf:params:netconf:capability:notification:1.0</capability></capabilities><session-id>[0-9]*</session-id></hello>]]>]]><rpc-reply message-id="101"><data/></rpc-reply>]]>]]>$'
 
 new "netconf get-config double quotes"
 expecteof "$clixon_netconf -qf $cfg" 0 '<rpc message-id="101" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"><get-config><source><candidate/></source></get-config></rpc>]]>]]>' '^<rpc-reply message-id="101" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"><data/></rpc-reply>]]>]]>$'