Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cl:creator attribute must be persistent #54

Closed
krihal opened this issue Oct 22, 2023 · 2 comments
Closed

cl:creator attribute must be persistent #54

krihal opened this issue Oct 22, 2023 · 2 comments
Assignees
@krihal
Labels
feature New feature or request fixed: plz verify Bug/feature is fixed by developer, need verification

Comments

@krihal
Copy link
Collaborator

krihal commented Oct 22, 2023

If a service is configured and a new chunk of XML is created with the cl:creator attribute set it must be persistent and survive a configuration pull otherwise it's not possible to remove the configuration generated by the service.
@krihal krihal added the feature New feature or request label Oct 22, 2023
@krihal krihal added the prio label Oct 23, 2023
olofhagsand added a commit to clicon/clixon that referenced this issue Nov 3, 2023
@olofhagsand
Fixed: [cl:creator attribute must be persistent](clicon/clixon-contro…
2f88ef3 
…ller#54)
olofhagsand added a commit that referenced this issue Nov 3, 2023
@olofhagsand
Test patch for #54
029a485
@olofhagsand olofhagsand assigned krihal and unassigned olofhagsand Nov 3, 2023
@olofhagsand olofhagsand added the fixed: plz verify Bug/feature is fixed by developer, need verification label Nov 3, 2023
@olofhagsand
Copy link
Member

Persistence fixed in the sense that it survives a configuration pull.
However, killing the controller and restarting it, and then do a pull will not re-create the attributes. It is not persistent in that sense.

@krihal
Copy link
Collaborator Author

krihal commented Nov 5, 2023

Tested with the bgp-peer service. Service configured and configuration pushed, did a pull and could remove the configuration again.

@krihal krihal closed this as completed Nov 5, 2023
@olofhagsand olofhagsand removed the prio label Nov 28, 2023
krihal pushed a commit to krihal/clixon-controller that referenced this issue Jul 1, 2024
@olofhagsand
Test patch for clicon#54
89956fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krihal krihal

Labels
feature New feature or request fixed: plz verify Bug/feature is fixed by developer, need verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krihal @olofhagsand