fix buffer size problem in cligen_parse_file() #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reading in a file exactly the same size as the buffer could leave the buffer not terminated with a 0 byte. figure out the size of the file allocate that + 1 byte. changed the file read to do it all in one chunk rather than byte by byte.
|
I can see the problem. But nothing is actually read, only the memset is made on the buffer and passed to parsing a string of 0:s? |
olofhagsand
added a commit
that referenced
this pull request
Jun 18, 2020
…eave the buffer not terminated with a 0 byte](#49)
|
Thanks for detecting. But fixed by this commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reading in a file exactly the same size as the buffer could leave the buffer not terminated with a 0 byte.
figure out the size of the file, then allocate that + 1 byte.
changed the file read to do it all in one chunk rather than byte by byte.
This change is sponsored by Rubicon Communications LLC (Netgate)