fix EC-CUBE#296 商品一覧, 商品詳細のパフォーマンス改善の動作に関して EC-CUBE#897

clicktx · Apr 18, 2024 · 9d07ed6 · 9d07ed6
1 parent aea89c3
commit 9d07ed6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/data/class/db/SC_DB_DBFactory.php b/data/class/db/SC_DB_DBFactory.php
@@ -256,7 +256,7 @@ public function alldtlSQL($where_products_class = '', $product_ids = array())
         // dtb_products_class の Full scan を防ぐため,
         // 商品IDが特定できている場合は, 先に product_id で対象を絞り込む
         if (count($product_ids) > 0) {
-            $in = SC_Utils_Ex::repeatStrWithSeparator('?', count($product_ids));
+            $in = implode(",", $product_ids);
             $product_id_cause = ' AND product_id IN ('.$in.')';
             $dtb_products_table = ' ( SELECT * FROM dtb_products WHERE product_id IN ('.$in.') ) AS dtb_products';
         }

diff --git a/tests/class/SC_Product/SC_Product_listsTest.php b/tests/class/SC_Product/SC_Product_listsTest.php
@@ -82,7 +82,7 @@ public function testlists_商品一覧取得()
             ),
         );
 
-        $this->actual = $this->objProducts->lists($this->objQuery);
+        $this->actual = $this->objProducts->lists($this->objQuery, array(1001, 1002));
 
         $this->verify('商品一覧');
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -82,7 +82,7 @@ public function testlists_商品一覧取得() @@
                 ),
             );
-            $this->actual = $this->objProducts->lists($this->objQuery);
+            $this->actual = $this->objProducts->lists($this->objQuery, array(1001, 1002));
             $this->verify('商品一覧');
         }
@@ Expand Down @@