-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tb.toString()
performance
#68
Comments
there probably are ways to speed it up, it "just" needs someone with a bit of time and knowledge of profiling 😉 |
Can you provide some more info like the Node.js version and a reproducible test case? |
Pending #278, which is intended to resolve a layout bug, includes some performance gains that can be furthered. After doing some further benchmarking, I believe it might be possible to get the layout rending of 100k cells to under or around 2 seconds—which might get close to "as good as it gets", or, roughly, a 3,600% decrease in rendering time at the least. Rendering 10k cells, would be well below 1 second (depending on table complexity). Insofar, only the I haven't written many performance tests, but think I'll take a stab at it. My hunch is to attempt to test for a time increase exceeding a threshold on nominally sized tables rather than rendering large tables and testing that they rendered within a fixed threshold. I'll try to post a PR with failing tests when I've got one and work from there! |
With the release of 0.6.2 and #278, the performance of cli-table3 should noticeably increase for nearly all large tables—while even small tables will render in substantially less time at a micro level. Using the performance testing tool at #294, rendering-time for a While this is 800% better, and likely sufficient in most cases, the memory consumption is still terrible and there is another ~2,500% decrease in rendering time that can be had! Update to v0.6.2+ for these (initial) performance enhancements.
|
The former was incredibly unperformant [1]. [1] cli-table/cli-table3#68
The former was incredibly unperformant [1]. [1] cli-table/cli-table3#68
Hello, I found that when the number of rows is huge, I start to have some performance problems.
I have 1763 rows (5 columns) and it takes me 4473.023ms to run
toString
method, I want to know if there is a way to improve the performance ?Thank you!
The text was updated successfully, but these errors were encountered: