Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clerk-js,types): Do not require current password if Reverifaction enabled #5284

Merged
merged 2 commits into from
Mar 7, 2025
Merged

feat(clerk-js,types): Do not require current password if Reverifaction enabled #5284

merged 2 commits into from
Mar 7, 2025

Conversation

chanioxaris
Copy link
Member

@chanioxaris chanioxaris commented Mar 5, 2025 •
edited by panteliselef
Loading

Description

Updates our <UserProfile /> in order to not require the current user password if Reverification is enabled on the instance. The user has already verified themselves via Reverification, so there is no point to ask them about their current password.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 65b386d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/clerk-expo Patch
@clerk/chrome-extension Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:01pm

@chanioxaris chanioxaris force-pushed the haris/user-1273-dont-require-current-password-when-reverification-is-enabled branch from 02dc703 to 133ab1e Compare March 5, 2025 12:07
@chanioxaris chanioxaris changed the title feat(clerk-js,expo,types): Don't require current password in case Reverifaction is enabled feat(clerk-js,clerk-expo,types): Don't require current password if Reverifaction enabled Mar 5, 2025
@chanioxaris chanioxaris changed the title feat(clerk-js,clerk-expo,types): Don't require current password if Reverifaction enabled feat(clerk-js,types): Don't require current password if Reverifaction enabled Mar 5, 2025
@nikospapcom nikospapcom changed the title feat(clerk-js,types): Don't require current password if Reverifaction enabled feat(clerk-js,types): Do not require current password if Reverifaction enabled Mar 5, 2025
@chanioxaris
feat(clerk-js,clerk-expo,types): Do not require current password if R…
fb0d012 
…everifaction enabled

We update our <UserProfile /> in order to not require the current user password if
Reverification is enabled on the instance. The user has already verified themselves
via Reverification, so there is no point to ask them about their current password.
@chanioxaris chanioxaris force-pushed the haris/user-1273-dont-require-current-password-when-reverification-is-enabled branch from 133ab1e to fb0d012 Compare March 5, 2025 12:19
@chanioxaris chanioxaris marked this pull request as ready for review March 5, 2025 15:24
chanioxaris
chanioxaris commented Mar 6, 2025
View reviewed changes
packages/clerk-js/src/core/resources/__tests__/__snapshots__/Environment.test.ts.snap
"claimedAt": null,
"pathRoot": "",
"singleSessionMode": true,
exports[`Environment __internal_toSnapshot() 1`] = `
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: It seems like the new snapshot has inverted the function orders, thus the many changes

@chanioxaris chanioxaris requested a review from a team March 6, 2025 11:59
@panteliselef @anagstef
Update .changeset/heavy-hornets-yawn.md
65b386d 
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
@chanioxaris chanioxaris merged commit 7ec95a7 into main Mar 7, 2025
30 checks passed
@chanioxaris chanioxaris deleted the haris/user-1273-dont-require-current-password-when-reverification-is-enabled branch March 7, 2025 08:50
@clerk-cookie clerk-cookie mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octoper octoper octoper approved these changes

@anagstef anagstef anagstef approved these changes

@panteliselef panteliselef panteliselef approved these changes

@nikospapcom nikospapcom Awaiting requested review from nikospapcom

Assignees
No one assigned
Labels
clerk-js expo types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chanioxaris @octoper @anagstef @panteliselef @clerk-cookie