-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,localizations,types): Support passkeys for first factor re-verification #5242
Conversation
🦋 Changeset detectedLatest commit: d70b949 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
27abd58
to
fb2cda3
Compare
fb2cda3
to
3ced70e
Compare
3ced70e
to
20ac845
Compare
d495016
to
b9ce886
Compare
b9ce886
to
2a3b724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🥳
packages/clerk-js/src/ui/components/UserVerification/UVFactorOnePasskeysCard.tsx
Outdated
Show resolved
Hide resolved
33ca323
to
050cbaa
Compare
…erification easier
if (!nonce) { | ||
// Throw an error if the nonce is not present | ||
throw new ClerkWebAuthnError('Passkeys are not supported', { | ||
code: 'passkey_not_supported', | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be an assertion similar to clerkMissingWebAuthnPublicKeyOptions('get')
. Actually you can skip this because you are checcking bellow for
const publicKeyOptions = nonce ? convertJSONToPublicKeyRequestOptions(JSON.parse(nonce)) : null;
if (!publicKeyOptions) {
clerkMissingWebAuthnPublicKeyOptions('get');
}
packages/clerk-js/src/ui/components/UserVerification/UserVerificationFactorOne.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: panteliselef <panteliselef@outlook.com>
Description
This PR introduces passkeys as a first factor strategy for re-verification
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change