Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Enable Keyless by default #4898

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Jan 15, 2025

Description

With this PR, anyone using @clerk/nextjs without explicit keys will run on Keyless.
To disable keyless use NEXT_PUBLIC_CLERK_KEYLESS_DISABLED=1.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

To disable keyless use `NEXT_PUBLIC_CLERK_KEYLESS_DISABLED=1`.
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: c5b7972

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 0:40am

…yless-enabled-by-default

# Conflicts:
#	packages/nextjs/src/utils/feature-flags.ts
@clerk clerk deleted a comment from clerk-cookie Jan 22, 2025
@clerk clerk deleted a comment from clerk-cookie Jan 22, 2025
@clerk clerk deleted a comment from clerk-cookie Jan 22, 2025
@clerk clerk deleted a comment from clerk-cookie Jan 22, 2025
@clerk clerk deleted a comment from clerk-cookie Jan 22, 2025
@clerk clerk deleted a comment from clerk-cookie Jan 23, 2025
@panteliselef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.1.16-snapshot.v20250124164447
@clerk/backend 1.23.8-snapshot.v20250124164447
@clerk/chrome-extension 2.2.2-snapshot.v20250124164447
@clerk/clerk-js 5.50.0-snapshot.v20250124164447
@clerk/elements 0.22.16-snapshot.v20250124164447
@clerk/clerk-expo 2.7.0-snapshot.v20250124164447
@clerk/expo-passkeys 0.1.15-snapshot.v20250124164447
@clerk/express 1.3.43-snapshot.v20250124164447
@clerk/fastify 2.1.16-snapshot.v20250124164447
@clerk/localizations 3.10.1-snapshot.v20250124164447
@clerk/nextjs 6.11.0-snapshot.v20250124164447
@clerk/nuxt 1.0.12-snapshot.v20250124164447
@clerk/clerk-react 5.22.7-snapshot.v20250124164447
@clerk/react-router 1.0.2-snapshot.v20250124164447
@clerk/remix 4.4.18-snapshot.v20250124164447
@clerk/shared 2.20.15-snapshot.v20250124164447
@clerk/tanstack-start 0.8.17-snapshot.v20250124164447
@clerk/testing 1.4.16-snapshot.v20250124164447
@clerk/themes 2.2.13-snapshot.v20250124164447
@clerk/types 4.44.1-snapshot.v20250124164447
@clerk/ui 0.3.17-snapshot.v20250124164447
@clerk/vue 1.1.7-snapshot.v20250124164447

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.16-snapshot.v20250124164447 --save-exact

@clerk/backend

npm i @clerk/backend@1.23.8-snapshot.v20250124164447 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.2-snapshot.v20250124164447 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.50.0-snapshot.v20250124164447 --save-exact

@clerk/elements

npm i @clerk/elements@0.22.16-snapshot.v20250124164447 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.7.0-snapshot.v20250124164447 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.15-snapshot.v20250124164447 --save-exact

@clerk/express

npm i @clerk/express@1.3.43-snapshot.v20250124164447 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.16-snapshot.v20250124164447 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.10.1-snapshot.v20250124164447 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.11.0-snapshot.v20250124164447 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.12-snapshot.v20250124164447 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.22.7-snapshot.v20250124164447 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.0.2-snapshot.v20250124164447 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.18-snapshot.v20250124164447 --save-exact

@clerk/shared

npm i @clerk/shared@2.20.15-snapshot.v20250124164447 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.17-snapshot.v20250124164447 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.16-snapshot.v20250124164447 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.13-snapshot.v20250124164447 --save-exact

@clerk/types

npm i @clerk/types@4.44.1-snapshot.v20250124164447 --save-exact

@clerk/ui

npm i @clerk/ui@0.3.17-snapshot.v20250124164447 --save-exact

@clerk/vue

npm i @clerk/vue@1.1.7-snapshot.v20250124164447 --save-exact

@clerk clerk deleted a comment from clerk-cookie Jan 24, 2025
@clerk clerk deleted a comment from clerk-cookie Jan 24, 2025
@panteliselef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.1.16-snapshot.v20250124164901
@clerk/backend 1.23.8-snapshot.v20250124164901
@clerk/chrome-extension 2.2.2-snapshot.v20250124164901
@clerk/clerk-js 5.50.0-snapshot.v20250124164901
@clerk/elements 0.22.16-snapshot.v20250124164901
@clerk/clerk-expo 2.7.0-snapshot.v20250124164901
@clerk/expo-passkeys 0.1.15-snapshot.v20250124164901
@clerk/express 1.3.43-snapshot.v20250124164901
@clerk/fastify 2.1.16-snapshot.v20250124164901
@clerk/localizations 3.10.1-snapshot.v20250124164901
@clerk/nextjs 6.11.0-snapshot.v20250124164901
@clerk/nuxt 1.0.12-snapshot.v20250124164901
@clerk/clerk-react 5.22.7-snapshot.v20250124164901
@clerk/react-router 1.0.2-snapshot.v20250124164901
@clerk/remix 4.4.18-snapshot.v20250124164901
@clerk/shared 2.20.15-snapshot.v20250124164901
@clerk/tanstack-start 0.8.17-snapshot.v20250124164901
@clerk/testing 1.4.16-snapshot.v20250124164901
@clerk/themes 2.2.13-snapshot.v20250124164901
@clerk/types 4.44.1-snapshot.v20250124164901
@clerk/ui 0.3.17-snapshot.v20250124164901
@clerk/vue 1.1.7-snapshot.v20250124164901

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.16-snapshot.v20250124164901 --save-exact

@clerk/backend

npm i @clerk/backend@1.23.8-snapshot.v20250124164901 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.2-snapshot.v20250124164901 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.50.0-snapshot.v20250124164901 --save-exact

@clerk/elements

npm i @clerk/elements@0.22.16-snapshot.v20250124164901 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.7.0-snapshot.v20250124164901 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.15-snapshot.v20250124164901 --save-exact

@clerk/express

npm i @clerk/express@1.3.43-snapshot.v20250124164901 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.16-snapshot.v20250124164901 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.10.1-snapshot.v20250124164901 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.11.0-snapshot.v20250124164901 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.12-snapshot.v20250124164901 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.22.7-snapshot.v20250124164901 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.0.2-snapshot.v20250124164901 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.18-snapshot.v20250124164901 --save-exact

@clerk/shared

npm i @clerk/shared@2.20.15-snapshot.v20250124164901 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.17-snapshot.v20250124164901 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.16-snapshot.v20250124164901 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.13-snapshot.v20250124164901 --save-exact

@clerk/types

npm i @clerk/types@4.44.1-snapshot.v20250124164901 --save-exact

@clerk/ui

npm i @clerk/ui@0.3.17-snapshot.v20250124164901 --save-exact

@clerk/vue

npm i @clerk/vue@1.1.7-snapshot.v20250124164901 --save-exact

@panteliselef panteliselef marked this pull request as ready for review January 30, 2025 16:33
@panteliselef panteliselef requested a review from a team January 30, 2025 16:33
@panteliselef panteliselef merged commit d332b79 into main Feb 3, 2025
29 checks passed
@panteliselef panteliselef deleted the elef/actls-50-cut-clerknextjskeyless-with-keyless-enabled-by-default branch February 3, 2025 19:24
@aldenquimby
Copy link

aldenquimby commented Feb 11, 2025

Hello! Where can I find documentation on what "keyless" means and whether or not I should be setting NEXT_PUBLIC_CLERK_KEYLESS_DISABLED=1? Our account modal started crashing after upgrading to @clerk/nextjs from 6.10 to 6.11, and I'm trying to figure out if this was the cause. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants