Skip to content

Commit

Permalink
Raise railties dependency to be compatible with Rails 5
Browse files Browse the repository at this point in the history 
Signed-off-by: Clemens Gruber <clemensgru@gmail.com>
  • Loading branch information
@clemensg
clemensg committed Jan 8, 2016
1 parent a9beeaf commit 05b6057
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion font-awesome-rails.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
gem.require_paths = ["lib"]
gem.version = FontAwesome::Rails::VERSION

gem.add_dependency "railties", ">= 3.2", "< 5.0"
gem.add_dependency "railties", ">= 3.2", "< 5.1"

gem.add_development_dependency "activesupport"
gem.add_development_dependency "sass-rails"
Expand Down

3 comments on commit 05b6057

@rmm5t
Copy link

@rmm5t rmm5t commented on 05b6057 Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably really be < 6.0 (because semver conventions) once we get the test suite passing against the Rails master branch.

@clemensg
Copy link
Owner Author

@clemensg clemensg commented on 05b6057 Jan 9, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmm5t
Copy link

@rmm5t rmm5t commented on 05b6057 Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 5.1 isn't wrong by any means. It's just a little more belts-n-suspenders. I'm fine leaving it as is, but issue bokmann#125 is the bigger blocker at the moment.

Please sign in to comment.