You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
When the lint tasks (specifically the golint command) fails we should exit 1. The only gotcha with this is the failure needs to allow the task to run first then check and fail. This way users can get the full golint output.
#!/bin/bash -eo pipefail
make lint
vendor/github.com/groob/mackit/example/password.go:24:2: comment not terminated
vendor/github.com/groob/mackit/example/password.go:38:3: expected '}', found 'EOF'
All .go files formatted correctly
/go/src/github.com/clburlison/bakeit/src/setup_linux.go:9:1: exported functionSetup should have comment or be unexported
/go/src/github.com/clburlison/bakeit/src/chef/client.go:1:1: package comment should be of the form "Package chef ..."
/go/src/github.com/clburlison/bakeit/src/config/config.go:66:2: exported var ChefClientLogLevel should have comment or be unexported
/go/src/github.com/clburlison/bakeit/src/config/config.go:68:2: comment on exported var ChefClientSSLVerifyMode should be of the form "ChefClientSSLVerifyMode ..."
/go/src/github.com/clburlison/bakeit/src/node/node.go:4:6: type name will be used as node.NodeInfoObject by other packages, and that stutters; consider calling this InfoObject
/go/src/github.com/clburlison/bakeit/src/serial/serial_linux.go:3:1: exported functionGetSerialNumber should have comment or be unexported
* test: Lint will now fail CI
Thanks to Victor for the set_exit_status tip.
Fix: #27
* style: Remove dup FirstRunLogFile config key
* style: Fix lint issues with client.go
* style: Fix lint issues with config.go
* style: Fix lint issues with node package
* style: Fix lint issues with Linux/Windows
* style: Update flight.go to not have double if
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When the
lint
tasks (specifically thegolint
command) fails we should exit 1. The only gotcha with this is the failure needs to allow the task to run first then check and fail. This way users can get the fullgolint
output.See https://circleci.com/gh/clburlison/bakeit/37
The text was updated successfully, but these errors were encountered: