Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Install msi #12

Closed
clburlison opened this issue Dec 20, 2017 · 2 comments
Closed

Install msi #12

clburlison opened this issue Dec 20, 2017 · 2 comments
Labels
windows
Milestone
0.2.0

Comments

@clburlison
Copy link
Owner

No description provided.

@clburlison clburlison added this to the 1.0 milestone Jan 3, 2018
clburlison added a commit that referenced this issue Jan 13, 2018
@clburlison
feat: Install msi on windows
7d0ab85 
The msi extra args are not being passed properly.
Address #12
@clburlison
Copy link
Owner Author

Install of the msi and log file are good but currently I'm unable to pass the extra args ADDLOCAL="ChefClientFeature,ChefSchTaskFeature,ChefPSModuleFeature"

@clburlison
Copy link
Owner Author

Go is already doing the escaping for us golang/go#15566

clburlison added a commit that referenced this issue Jan 23, 2018
@clburlison
fix: Support ADDLOCAL option with msi installs
5d2cf6c 
msiexec.exe didn't like these values since  exec.Command was already doing the escaping.

Fix: #12
@clburlison clburlison mentioned this issue Jan 23, 2018
Merged
clburlison added a commit that referenced this issue Feb 24, 2018
@clburlison
fix: Support ADDLOCAL option with msi installs
a6f029f 
msiexec.exe didn't like these values since  exec.Command was already doing the escaping.

Fix: #12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@clburlison