Repair issues with HA 2023.6.0 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes as identified in issue claytonjn#227
|
You have a duplicate line of code. Line 378 is unnecesary, and could potentially cause problems since it skips the verification (next line is an if that checks that the object is not a NoneType). |
|
Yup. Just remove the line 378 you have added.
Also keep in |
Removed additional line of code
|
Will fix Hassfest validation when I version bump for release. |
|
Thanks everyone, seems as though I made it more difficult than it ought to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes as identified in issue #227 which fixes issues with Home Assistant 2023.6.0. This is my first PR so not sure exactly how this process works!