-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dynamic commission acc seq fix #386
Conversation
fix-dyncomm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that looks good from my side.
My suggestion would be to introduce a "legacy" dyncomm ante decorator that only runs the dyncomm ante handler for "<" specified block height. The normal one would run for ">=" specified block height.
This way the chain could be forked without explicitly halting the chain.
I think the validators complained about not having a proposal for notifying them about the update, so maybe a proposal with chain halt is the best way to make sure they all see it. |
Summary of changes
Report of required housekeeping
(FOR ADMIN) Before merging