fix: set default iavl-disable-fastnode to true
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alchemist-ti
approved these changes
Sep 4, 2023
nghuyenthevinh2000
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the new classic-terra/cosmos-sdk v0.46.14-terra.2 to set iavl-disable-fastnode to true by default. The iavl-disable-fastnode and iavl-disable-fastnode settings can also be controlled using app.toml.
Background (Ref: classic-terra/cosmos-sdk#12)
In the past, the value of iavlDisableFastNodeDefault in Terra Classic was set to true, so the IAVL FastNode feature has never been used in Terra Classic. If this value is changed to false, migration will be forced to occur at every node startup.
When testing the migration of Columbus-5, it took approximately 50 minutes on a machine with a 3.6Ghz Intel Core i9 and 128GB of memory.
In addition, the recently discovered bug in IAVL (cosmos/iavl#805) only occurs in nodes using IAVL fast node.