-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Smart Contract Tax Whitelist #301
Conversation
@alchemist-ti while waiting for USTC team response, can you work on this |
@alchemist-ti I think the unit test is broken somehow, when I try with feeAmt * 2 for "MsgExecuteContract(exemption), MsgExecuteContract(normal)", it also passes as well. So this is false positive scenario. |
@nghuyenthevinh2000 This test case makes sense. ExpectedFeeAmount means the minimum FeeAmount, if gas fee is greater than it, the transaction will pass. |
ExpectedFeeAmount means the correct amount. I built this test case to ensure that fee calculation will be skipped only on whitelisted <-> whitelisted. Please have a look again. |
For Cosmos, unused gas fees are not refunded, so if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working, thanks you @alchemist-ti
This is the Whitelist that passed governance. Description of acceptance criteria can be found here. This Changeset includes:
HasBurnTaxExemptionContract
function to treasury keeper