Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add mergify #294

Merged
merged 2 commits into from
Jun 27, 2023
Merged

tools: add mergify #294

merged 2 commits into from
Jun 27, 2023

Conversation

alchemist-ti
Copy link
Contributor

@alchemist-ti alchemist-ti commented Jun 26, 2023 •
edited
Loading

Summary of changes

Closes: #212, powered by https://mergify.com.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@alchemist-ti alchemist-ti added the github_actions Pull requests that update GitHub Actions code label Jun 26, 2023
@alchemist-ti
Copy link
Contributor Author

After this PR is merged, you can backport the PRs to the release/v2.1.x branch by adding the backport/v2.1.x label.

@alchemist-ti alchemist-ti self-assigned this Jun 26, 2023
shackra
shackra reviewed Jun 26, 2023
View reviewed changes
.mergify.yml Show resolved Hide resolved
shackra
shackra approved these changes Jun 26, 2023
View reviewed changes
Copy link

@shackra shackra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment, LGTM.

inon-man
inon-man approved these changes Jun 27, 2023
View reviewed changes
.mergify.yml Show resolved Hide resolved
@nghuyenthevinh2000 nghuyenthevinh2000 merged commit b7c3be9 into classic-terra:main Jun 27, 2023
@alchemist-ti alchemist-ti deleted the backport branch June 28, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shackra shackra shackra approved these changes

@inon-man inon-man inon-man approved these changes

@nghuyenthevinh2000 nghuyenthevinh2000 Awaiting requested review from nghuyenthevinh2000

@fragwuerdig fragwuerdig Awaiting requested review from fragwuerdig

Assignees

@alchemist-ti alchemist-ti

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to have a backport github workflow to propagate changes from main to other release
4 participants
@alchemist-ti @shackra @inon-man @nghuyenthevinh2000