Prevent access of invalid references #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some calls to
this.shakaPlayerInstance.getManifest()
are doing before one valid shaka player instance exists. This PR prevents those access to avoid log noises.Changes
null
onpresentationTimeline
getter ifthis.shakaPlayerInstance.getManifest()
doesn't exists;0
ongetProgramDateTime
method ifthis.presentationTimeline
returns invalid value;How to test
console
tab of yourdevelopers tools
;presentationTimeline
ofnull
.A picture is worth a thousand words
Before
Screen.Recording.2021-01-06.at.10.27.31.mov
After
Screen.Recording.2021-01-06.at.10.24.51.mov