Enable multiple calls to _setup() method #90
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if the
_setup()
is called after the playback is ready/started to play, one error (code 3015) occurs when thesetInterval
loop on_startTimeUpdateTimer
method tries to update the current time of the old shaka-player instance in the time interval between the_setup
method is called and one new shaka-player instance is created.This PR guarantees the delete of the old shaka-player instance (if exists) before the creation of the new one.
Changes
_setInitialConfig
);_loadSource
);runAllSteps
);runAllSteps
call with thethis._player.destroy
promise ifthis_player
exists;How to test
player.core.activePlayback._options.src = 'your-new-media.mpd'
._setup
method;A picture is worth a thousand words
Before
Screen.Recording.2021-01-06.at.10.02.12.mov
After
Screen.Recording.2021-01-06.at.10.01.11.mov