Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite HTML5Video inherited methods #87

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

joaopaulovieira
Copy link
Member

Summary

This PR updates seek and pause methods to overwrite HTML5Video Class inherits.

Changes

  • Set the current time on video element when the seek(time) method is called;
  • Call videoElement.pause method when pause plugin method is called;

How to test

All changes in this PR should not impact any use of the DashShakaPlayback.

Copy link
Member

@leandromoreira leandromoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just out of curiosity, why?

@joaopaulovieira
Copy link
Member Author

joaopaulovieira commented Oct 29, 2020

@leandromoreira In the latest version of clappr-core, we add behaviors in these inherit methods via HTML5Video that probably cause problems if one playback call super and do other operations.

So, to avoid one bigger refactoring, we can just stop calling super and do the operation on the video element directly on playback implementation.

@jhonatangcavalcanti jhonatangcavalcanti merged commit 64ce8bb into master Nov 5, 2020
@jhonatangcavalcanti jhonatangcavalcanti deleted the overwrite-html5-methods branch November 5, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants