Skip to content

Commit

Permalink
refactor(dash): handle error on super when error is unknown
Browse files Browse the repository at this point in the history
  • Loading branch information
jhonatangcavalcanti authored and vagnervjs committed May 3, 2018
1 parent bdeb309 commit 2f1d7c4
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/clappr-dash-shaka-playback.js
Original file line number Diff line number Diff line change
Expand Up @@ -315,22 +315,23 @@ class DashShakaPlayback extends HTML5Video {
videoError: this.el.error
}

if (error.videoError) return super._onError()

let { category, code, severity } = error.shakaError.detail || error.shakaError

if (error.videoError || !code && !category) return super._onError()

const isCritical = severity === shaka.util.Error.Severity.CRITICAL
const errorData = {
code: `${category}_${code}`,
description: `Category: ${category}, code: ${code}, severity: ${severity}`,
level: severity === 1 ? PlayerError.Levels.WARN : PlayerError.Levels.FATAL,
level: isCritical ? PlayerError.Levels.FATAL : PlayerError.Levels.WARN,
raw: err
}
const formattedError = this.createError(errorData)
Log.error('Shaka error event:', formattedError)
this.trigger(Events.PLAYBACK_ERROR, formattedError)
}


_onAdaptation () {
let activeVideo = this.videoTracks.filter((t) => t.active === true)[0]

Expand Down

0 comments on commit 2f1d7c4

Please sign in to comment.