Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reshape function to Array class #243

Merged
merged 1 commit into from
Sep 29, 2024
Merged

add reshape function to Array class #243

merged 1 commit into from
Sep 29, 2024

Conversation

haesleinhuepf
Copy link
Member

Hi Stephane @StRigaud

I had an error deep inside napari, that our Array class does not have a "reshape" function. This should fix the error.

Best,
Robert

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (83af46d) to head (68fa295).

Files with missing lines Patch % Lines
pyclesperanto/_array.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   88.09%   88.05%   -0.04%     
==========================================
  Files          19       19              
  Lines        1638     1641       +3     
==========================================
+ Hits         1443     1445       +2     
- Misses        195      196       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

I think I already hit a wall there, but there is no possibility to reshape directly in the GPU?

From memory I think tried but did not manage easily, hence dropped it for latter ...

I will merge this for the 0.13.4

@StRigaud StRigaud merged commit bfe5dff into main Sep 29, 2024
7 checks passed
@StRigaud StRigaud deleted the reshape branch October 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants