-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add notebook for benchmarking top_hat #201
Conversation
That's .... suspicious (or great, idk). I run the notebook on my GPU:
I cannot explain the speed gain, but I am happy for it I guess. Can you make sure all is correct ? |
@haesleinhuepf, this could be related to a possible acceleration from the |
@haesleinhuepf this is because of the data type! If you run the filters on See my updates on the notebook. PS: also you inversed the disk and square for the skimage footprint. The sphere is REALLY slow for me .... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 18 18
Lines 1830 1830
=======================================
Hits 1554 1554
Misses 276 276 ☔ View full report in Codecov by Sentry. |
ready to be merge, unless we want to add more |
In this notebook you can see that top-hat-box in the non-prototype is much faster than in in the protoype. Any ideas why? This could be interesting for the paper, and potentially speed up other operations too.