Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix param name to fit prototype #375

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

StRigaud
Copy link
Member

closes #371

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.73%. Comparing base (4c18fc0) to head (19c95ca).

Files with missing lines Patch % Lines
clic/src/tier4/filter_label_by_values.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   48.75%   48.73%   -0.03%     
==========================================
  Files         243      243              
  Lines        3942     3944       +2     
  Branches     1800     1800              
==========================================
  Hits         1922     1922              
- Misses        602      604       +2     
  Partials     1418     1418              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud StRigaud merged commit d61a5a0 into master Oct 17, 2024
5 checks passed
@StRigaud StRigaud deleted the fix-exclude-filter-param-name branch October 18, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter order of exclude_labels_with_map_values_out_of_range is wrong compared to the _prototype
2 participants