Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix min/max to minimum maximum #357

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix min/max to minimum maximum #357

merged 2 commits into from
Oct 10, 2024

Conversation

StRigaud
Copy link
Member

@StRigaud StRigaud commented Oct 10, 2024

rename param:

  • min_size to minimum_size
  • max_size to maximum_size

closes clEsperanto/pyclesperanto#255

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.17%. Comparing base (fc0ed1c) to head (0802b5f).

Files with missing lines Patch % Lines
clic/src/tier6/remove_objects.cpp 0.00% 6 Missing ⚠️
clic/src/tier5/filter_label_by_size.cpp 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   49.16%   49.17%   +0.01%     
==========================================
  Files         243      243              
  Lines        3950     3951       +1     
  Branches     1792     1792              
==========================================
+ Hits         1942     1943       +1     
  Misses        600      600              
  Partials     1408     1408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud StRigaud merged commit e0334ee into master Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error after upgrading to pyclesperanto without prototype
2 participants