Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small bug #353

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix a small bug #353

merged 1 commit into from
Oct 3, 2024

Conversation

tpietzsch
Copy link
Contributor

Coming next after BINARY = UINT8, UNKNOWN is assigned the equivalent int value after UINT8, that is, INT16.

if (dType::UNKNOWN == dType::INT16)
    std::cout << "oops" << std::endl;

Coming next after "BINARY = UINT8", "UNKNOWN" is assigned the equivalent int
value after UINT8, that is, INT16.

if (dType::UNKNOWN == dType::INT16)
    std::cout << "oops" << std::endl;
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (85cee98) to head (70f7437).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files         243      243           
  Lines        3950     3950           
  Branches     1792     1792           
=======================================
  Hits         1942     1942           
  Misses        600      600           
  Partials     1408     1408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

StRigaud commented Oct 3, 2024

thanks Tobias

@StRigaud StRigaud merged commit fc0ed1c into clEsperanto:master Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants