reduce bia-bob suggestions #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haesleinhuepf
commented
Sep 29, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 49.18% 49.18%
=======================================
Files 243 243
Lines 3948 3948
Branches 1792 1792
=======================================
Hits 1942 1942
Misses 597 597
Partials 1409 1409 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com> Signed-off-by: Stephane Rigaud <Stephane.rigaud@pasteur.fr>
StRigaud
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, I'm just removing some bia-bob suggestions to keep the list of suggested functions short. I tried to promote new function names such as "remove_small_labels" and did not keep "exclude_small_labels".
closes #347
closes clEsperanto/pyclesperanto#245
git-bob couldn't do this btw, as the file size exceeds OpenAI token limits :-D