Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename-read/write/copy-functions #324

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

StRigaud
Copy link
Member

renaming of the read/write/copy function to a more readable name:

readTo -> read the gpu to the host
writeFrom -> write the gpu from the host
copyTo -> copy the gpu to the gpu

closes #323

@haesleinhuepf

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 28.94737% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.71%. Comparing base (679bd1b) to head (4bc296e).

Files Patch % Lines
clic/src/tier2/extend_labeling_via_voronoi.cpp 0.00% 0 Missing and 3 partials ⚠️
clic/src/tier3/maximum_position.cpp 0.00% 0 Missing and 3 partials ⚠️
clic/src/tier3/minimum_position.cpp 0.00% 0 Missing and 3 partials ⚠️
clic/src/tier3/exclude_labels.cpp 0.00% 0 Missing and 2 partials ⚠️
clic/src/tier3/exclude_labels_on_edges.cpp 0.00% 0 Missing and 2 partials ⚠️
clic/src/transform.cpp 0.00% 1 Missing and 1 partial ⚠️
clic/src/array.cpp 90.90% 0 Missing and 1 partial ⚠️
clic/src/tier1/write_values_to_positions.cpp 0.00% 0 Missing and 1 partial ⚠️
clic/src/tier2/maximum_of_all_pixels.cpp 0.00% 0 Missing and 1 partial ⚠️
clic/src/tier2/minimum_of_all_pixels.cpp 0.00% 0 Missing and 1 partial ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   46.71%   46.71%           
=======================================
  Files         235      235           
  Lines        3155     3155           
  Branches     1583     1583           
=======================================
  Hits         1474     1474           
  Misses        440      440           
  Partials     1241     1241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud StRigaud merged commit b1d6029 into master Jul 15, 2024
5 checks passed
@StRigaud StRigaud deleted the rename-read/write/copy-functions branch July 15, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: pull_array and pull_vector
2 participants