Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] copy dlls in tests build folder #314

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[windows] copy dlls in tests build folder #314

merged 2 commits into from
Jul 12, 2024

Conversation

StRigaud
Copy link
Member

@StRigaud StRigaud commented Jul 2, 2024

... so that tests can be run without copying manually the dlls or adding them to the path.

This only concern windows. And it was not yet tests.

closes #250

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.34%. Comparing base (437bcd3) to head (69c2833).
Report is 207 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   50.09%   47.34%   -2.75%     
==========================================
  Files          15      235     +220     
  Lines        3222     3128      -94     
  Branches     1364     1550     +186     
==========================================
- Hits         1614     1481     -133     
+ Misses        532      419     -113     
- Partials     1076     1228     +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@haesleinhuepf haesleinhuepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my Windows machine and it works!!

Big thanks @StRigaud

@StRigaud StRigaud merged commit 679bd1b into master Jul 12, 2024
5 checks passed
@StRigaud StRigaud deleted the windows-cpy-dll branch July 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building/testing on windows requires manual copying of dll-files
3 participants